[MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier #9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SGDClassifier for proper deprecation.
jnothman
changed the title
|
LGTM |
|
gonna fix doctests asap |
|
finally green |
NelleV
approved these changes
Aug 16, 2017
|
Thanks :) |
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…arn#9558) * move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation. * move validate_params so we have self._max_iter in _fit * validate params in init because the tests wants me to * better check for input validation * fix deprecation tests to call _validate_params * fix parameter validation in PA classifier * fix max_iter in doctests * pep8 /doctest whitespace * more doctests * maybe I'll find them all....
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 23, 2017
…arn#9558) * move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation. * move validate_params so we have self._max_iter in _fit * validate params in init because the tests wants me to * better check for input validation * fix deprecation tests to call _validate_params * fix parameter validation in PA classifier * fix max_iter in doctests * pep8 /doctest whitespace * more doctests * maybe I'll find them all....
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…arn#9558) * move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation. * move validate_params so we have self._max_iter in _fit * validate params in init because the tests wants me to * better check for input validation * fix deprecation tests to call _validate_params * fix parameter validation in PA classifier * fix max_iter in doctests * pep8 /doctest whitespace * more doctests * maybe I'll find them all....
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…arn#9558) * move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation. * move validate_params so we have self._max_iter in _fit * validate params in init because the tests wants me to * better check for input validation * fix deprecation tests to call _validate_params * fix parameter validation in PA classifier * fix max_iter in doctests * pep8 /doctest whitespace * more doctests * maybe I'll find them all....
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…arn#9558) * move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation. * move validate_params so we have self._max_iter in _fit * validate params in init because the tests wants me to * better check for input validation * fix deprecation tests to call _validate_params * fix parameter validation in PA classifier * fix max_iter in doctests * pep8 /doctest whitespace * more doctests * maybe I'll find them all....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9549.