[MRG+1] supress deprecation warnings for non_negative option #9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghui-liu
changed the title
|
Could you copy the logs of running nose tests over this module to check that it's warning free? |
|
Please |
|
Sure. Here is the output of running |
|
LGTM |
jnothman
changed the title
|
thx @Kevinlmh |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9319
What does this implement/fix? Explain your changes.
use
sklearn.utils. testing.ignore_warningsto supress deprecation warnings fornon_negativeoption in some Vectorizer tests.Any other comments?
No.