-
-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG + 1] codecov: disable comments #8502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was fast 👍
Codecov Report
@@ Coverage Diff @@
## master #8502 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 342 342
Lines 60913 60913
=======================================
Hits 58160 58160
Misses 2753 2753 Continue to review full report at Codecov.
|
thanks :) |
LGTM |
Thank you! This also makes me happy :) |
didn't work :( |
should have been "comment". Fixing in master... |
should have been
good thing we're reviewing so well. |
For the record I think comments were useful and the fact that you only get one email per PR rather than one per-commit was a good trade-off as far as email noise is concerned. Having said that I agree that there is a bit of noise in the numbers that codecov reports (which we should try to understand at some point) and that the one comment per PR does not always work for some unknown reason (I thought it was due to rebase and force-push but this doesn't seem like the culprit in some small tests I ran). |
This should make some people more happy