-
-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] CCA low rank doesn't crash any more #4420
Conversation
@ogrisel this might be interesting for a back-port as it makes PLS and CCA not throw up on simple 1d data. |
|
|
else: | ||
X = np.asarray(X) | ||
Xc -= self.x_mean_ | ||
Xc /= self.x_std_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there is a spurious indent on this line: the data is not scaled by self.x_std_
when copy=False
(agreed the bug was already there prior to you PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it anyhow
|
|
added tests |
LGTM. +1 for merge on my side. Any quick second review? Would be great to have those fixes in 0.16. |
Probably also fixes #954 but that needs to be confirmed. |
@GaelVaroquaux maybe there is someone at the sprint to review this? ;) |
👍 |
FIX CCA low rank doesn't crash any more
Thanks @NelleV ! |
Well thank you!! You've not only fixed the bug but also cleaned up the code
|
Well thank you!! You've not only fixed the bug but also cleaned up the code
nicely.
+10!
|
Fixes #4419.
Also adds some misc shape fixes and input validation so that cross-decomposition passes the common tests.