Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix f_oneway with ints #2671

Merged
merged 2 commits into from
Dec 16, 2013
Merged

Conversation

agramfort
Copy link
Member

address #2670

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f31d6d7 on agramfort:fix_f_oneway_int into aac7e67 on scikit-learn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f31d6d7 on agramfort:fix_f_oneway_int into aac7e67 on scikit-learn:master.

@jnothman
Copy link
Member

Should we not be using from __future__ import division in any file with a / operation to ensure Py3 consistency?

@agramfort
Copy link
Member Author

Should we not be using from future import division in any file with a
/ operation to ensure Py3 consistency?

maybe. Still my patch solves the issue

@GaelVaroquaux
Copy link
Member

Let's go with @agramfort's solution, because it is a fix for now. 👍
for merge on my side.

@jnothman
Copy link
Member

Okay. +1

On Tue, Dec 17, 2013 at 10:12 AM, Gael Varoquaux
notifications@github.comwrote:

Let's go with @agramfort's solution, because it is a fix for now. 👍
for merge on my side.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2671#issuecomment-30711255
.

@GaelVaroquaux
Copy link
Member

Merging.

GaelVaroquaux added a commit that referenced this pull request Dec 16, 2013
@GaelVaroquaux GaelVaroquaux merged commit d4c5b18 into scikit-learn:master Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants