Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

ruff is not available here in the linter since it's a pull_request_target and is using the version from main.

Run ./build_tools/linting.sh &> /tmp/linting_output.txt
  ./build_tools/linting.sh &> /tmp/linting_output.txt
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.11.4/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.4/x64/lib
Error: Process completed with exit code 1.

but the linter bot comment is still sunny.

I tried the pre-commit hook locally and it's green:

$ pre-commit run ruff -a
ruff.....................................................................Passed

Maybe the linter should do something like:

./build_tools/linting.sh 2>&1 | tee /tmp/linting_output.txt

so that we can access the raw output of the linting.sh script in the logs of the CI when the bot does not pick it up for some reason?

@ogrisel the next step (comment) already prints the log, so you can see that there.

The failure in the linter is really not supposed to happen in usually though. This is very specific to this PR (or changing linting tools / dependencies) which we do very rarely.

@ogrisel the next step (comment) already prints the log, so you can see that there.

Yes I found out, after commenting:

https://github.com/scikit-learn/scikit-learn/actions/runs/5322327168/jobs/9638664632#step:6:16

What @thomasjpfan implies above is that 6188b36 will only have an effect once this PR is merged because it's a change in the workflow file? If so, +1 for merge.

Note, I think this is causing CI runs more recent than this PR (?) that have not rebased with main to fail 'linter / lint (pull_request_target)' with error:

### Running flake8 ###

./build_tools/linting.sh: line 26: flake8: command not found
Problems detected by flake8, please fix them

Though confusingly github actions bot tells you that 'Linting Passed'. Solved by rebasing with main.
see: #26643, #26641

cc @adrinjalali

@lucyleeow #26638 should fix the issue.

@adrinjalali Thanks for pushing ruff!