Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update validate_parameter_constraints() docstring. #24130

Conversation

stefmolin
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

The docstring for validate_parameter_constraints() listing the options available isn't up to date. This add options that were currently missing.

Any other comments?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Aug 7, 2022
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @stefmolin!

@jjerphan jjerphan merged commit f09f8dd into scikit-learn:main Aug 8, 2022
@stefmolin stefmolin deleted the doc/update_validate_parameter_contraints_docstring branch August 8, 2022 17:06
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation module:utils Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants