DOC Ensures that extmath.cartesian passes numpydoc validation #21513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Oct 30, 2021
sklearn/utils/extmath.py
Outdated
| @@ -668,6 +668,11 @@ def cartesian(arrays, out=None): | |||
| 2-D array of shape (M, len(arrays)) containing cartesian products | |||
There was a problem hiding this comment.
Could you modify the signature of out with:
out : ndarray of shape (M, len(arrays))
Array containing the cartesian products formed of input arrays.
Please edit as the out parameter of the Parameters section
ogrisel
approved these changes
Oct 30, 2021
|
Done it, All checks have passed 😄, what's next ? |
|
Just a quick fix for the |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…-learn#21513) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…-learn#21513) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Dec 25, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
This is my first PR in scikit-learn during #DataUmbrella sprint.
Any other comments?