DOC Ensures that balanced_accuracy_score passes numpydoc validation #21478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Oct 28, 2021
glemaitre
reviewed
Oct 28, 2021
…lanced_accuracy under the Returns section
ogrisel
reviewed
Oct 29, 2021
sklearn/metrics/_classification.py
Outdated
| average_precision_score : Compute average precision (AP) from prediction | ||
| scores. | ||
| recall_score : Compute the ratio ``tp / (tp + fn)``, where ``tp`` is | ||
| the number of true positives and ``fn`` the number of false negatives. |
There was a problem hiding this comment.
If we mention recall_score, we should also mentionprecision_score (in addition toaverage_precision_score).
glemaitre
reviewed
Nov 2, 2021
|
Apart of this last comment, I am happy with the PR. |
adrinjalali
approved these changes
Nov 5, 2021
jjerphan
approved these changes
Nov 7, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
#DataUmbrella
This PR ensures balanced_accuracy_score is compatible with numpydoc: