Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Simplify the test and remove empty DOCSTRING_IGNORE_LIST #21468

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

Icyshaman
Copy link
Contributor

@Icyshaman Icyshaman commented Oct 26, 2021

Reference Issues/PRs

Fixes #20308

What does this implement/fix? Explain your changes.

  • Removed the empty DOCSTRING_IGNORE_LIST in test_docstrings.py.

Any other comments?

#DataUmbrella sprint

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The PyPy timeout is unrelated.

@thomasjpfan thomasjpfan changed the title Simplify the test and remove the empty DOCSTRING_IGNORE_LIST TST Simplify the test and remove the empty DOCSTRING_IGNORE_LIST Oct 27, 2021
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title TST Simplify the test and remove the empty DOCSTRING_IGNORE_LIST TST Simplify the test and remove empty DOCSTRING_IGNORE_LIST Oct 27, 2021
@thomasjpfan thomasjpfan merged commit d412952 into scikit-learn:main Oct 27, 2021
@reshamas reshamas added the Sprint label Nov 5, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that docstrings pass numpydoc validation
4 participants