Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Ensures that sklearn.model_selection._validation.cross_val_predict passes numpydoc validation #21433

Merged
merged 1 commit into from
Oct 23, 2021
Merged

DOC Ensures that sklearn.model_selection._validation.cross_val_predict passes numpydoc validation #21433

merged 1 commit into from
Oct 23, 2021

Conversation

iofall
Copy link
Contributor

@iofall iofall commented Oct 23, 2021

Reference Issues/PRs
Addresses #21350

What does this implement/fix? Explain your changes.

  • remove sklearn.model_selection._validation.cross_val_predict from scikit-learn/maint_tools/test_docstrings.py
  • fix numpydoc validation error in sklearn.model_selection._validation.cross_val_predict

Any other comments?
cc (pair programming partner): @arisayosh

Yields Issue
We fixed the : YD01: No Yields section found flake8 error by removing yielding from the docstring.

#DataUmbrella sprint
cc: @nestornav

…validation_cross_val_predict

Co-authored-by: iofall <50991099+iofall@users.noreply.github.com>
Co-authored-by: arisayosh <15692997+arisayosh@users.noreply.github.com>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel ogrisel merged commit 92544c7 into scikit-learn:main Oct 23, 2021
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Oct 28, 2021
…validation_cross_val_predict (scikit-learn#21433)

Co-authored-by: iofall <50991099+iofall@users.noreply.github.com>

Co-authored-by: arisayosh <15692997+arisayosh@users.noreply.github.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…validation_cross_val_predict (scikit-learn#21433)

Co-authored-by: iofall <50991099+iofall@users.noreply.github.com>

Co-authored-by: arisayosh <15692997+arisayosh@users.noreply.github.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
…validation_cross_val_predict (scikit-learn#21433)

Co-authored-by: iofall <50991099+iofall@users.noreply.github.com>

Co-authored-by: arisayosh <15692997+arisayosh@users.noreply.github.com>
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
…validation_cross_val_predict (#21433)

Co-authored-by: iofall <50991099+iofall@users.noreply.github.com>

Co-authored-by: arisayosh <15692997+arisayosh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants