DOC Ensures that SpectralEmbedding passes numpydoc validation #21411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Oct 23, 2021
amueller
approved these changes
Oct 23, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
@amueller @glemaitre Thanks so much for reviewing my PR. It's a honor for me! |
adrinjalali
approved these changes
Oct 23, 2021
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Oct 28, 2021
…-learn#21411) * DOC Ensures that SpectralEmbedding passes numpydoc validation * Trim trailing whitespace * Add space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Remove space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…-learn#21411) * DOC Ensures that SpectralEmbedding passes numpydoc validation * Trim trailing whitespace * Add space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Remove space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…-learn#21411) * DOC Ensures that SpectralEmbedding passes numpydoc validation * Trim trailing whitespace * Add space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Remove space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Dec 25, 2021
* DOC Ensures that SpectralEmbedding passes numpydoc validation * Trim trailing whitespace * Add space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * Remove space Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR ensures
SpectralEmbeddingis compatible with numpydoc.SpectralEmbeddingfrom:scikit-learn/maint_tools/test_docstrings.py
Line 21 in d4d5f8c
Isomap.Any other comments?
Thanks #DataUmbrella! Thanks so much scikit-learn for so patiently reviewing my PRs! Please let me know if there is anything I can do to improve my future PRs.