Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Ensures that IsotonicRegression passes numpydoc validation #20514

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

embandera
Copy link
Contributor

Reference Issues/PRs

Addresses #20308
#DataUmbrella Sprint

What does this implement/fix? Explain your changes.

Any other comments?

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion for further improvement:

sklearn/isotonic.py Show resolved Hide resolved
sklearn/isotonic.py Outdated Show resolved Hide resolved
@glemaitre glemaitre merged commit 09df953 into scikit-learn:main Jul 20, 2021
@glemaitre
Copy link
Member

Thanks @embandera

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…t-learn#20514)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants