DOC Ensures that NuSVC passes numpydoc validation #20461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still numpydoc validation tests that are failing. |
|
Yeah. Once this PR get merged, these issues will be resolved. |
glemaitre
changed the title
|
When #20457 is merged then you can merge |
|
@glemaitre, @thomasjpfan If you have a minute, can you check this PR? |
|
All good. Thanks @jmloyola |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR ensures NuSVC is compatible with numpydoc.
NuSVCfromDOCSTRING_IGNORE_LIST.Any other comments?
For this PR to pass all numpydoc test, this PR should be merged before.
#DataUmbrella Sprint