Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Ensures that RFE passes numpydoc validation #20419

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

jaglima
Copy link
Contributor

@jaglima jaglima commented Jun 28, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

Fixes numpydoc errors on RFE functions.

Any other comments?

#DataUmbrella sprint
cc. @jaglima

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Just a small suggestion in the phrasing:

sklearn/feature_selection/_rfe.py Outdated Show resolved Hide resolved
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@ogrisel ogrisel merged commit e59a6c0 into scikit-learn:main Jun 29, 2021
@ogrisel
Copy link
Member

ogrisel commented Jun 29, 2021

Thanks @jaglima!

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants