DOC ensures DBSCAN docstring passes numpydoc validation #20375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
glemaitre
reviewed
Jun 26, 2021
glemaitre
approved these changes
Jun 26, 2021
|
This looks great, thanks for the feedback! |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
@glemaitre is there a way to re-run the CI without doing something like an empty commit? It seems like a step failed due to timeout |
glemaitre
reviewed
Jun 28, 2021
|
@fbidu The failure is unrelated (just a timeout of one of the mac build). Everything is alright. Merging. Thanks |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…#20375) Co-authored-by: Iván Pulido <ivanpulido@protonmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR makes dbscan compatible with numpydoc
Any other comments?
cc: @ijpulidos