Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Ensures that LogisticRegression passes numpydoc validation #20370

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

lacouth
Copy link
Contributor

@lacouth lacouth commented Jun 26, 2021

#DataUmbrella sprint

Reference Issues/PRs

Adresses #20308

cc.: @gitdoluquita pair programming partner

What does this implement/fix? Explain your changes.

Removing LogisticRegression from DOCSTRING_IGNORE_LIST

Any other comments?

All tests already passed

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I run the test locally and it passes.
We will wait for the CIs to agree just to be sure.

@glemaitre glemaitre merged commit d936b1b into scikit-learn:main Jun 26, 2021
@glemaitre
Copy link
Member

Thanks @lacouth All good.

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants