MNT Use a minimal Windows Docker container to check the wheels #18802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaro96
changed the title
ogrisel
reviewed
Nov 18, 2020
ogrisel
reviewed
Nov 18, 2020
…t-learn into minimal_windows_container
|
It seems that we still have problems with the find command (although rarer): https://github.com/scikit-learn/scikit-learn/runs/1418596447 |
ogrisel
reviewed
Nov 18, 2020
|
Waiting for a green :) Edit: Green in the |
|
Thank you very much for fixing this @alfaro96 ! |
|
Can you please open an issue not to forget about #18802 (comment) . |
|
I would not say that it was easy, but I am really happy with the result (and thank you @ogrisel for your work and reviews). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes MacPython/scikit-learn-wheels#44.
What does this implement/fix? Explain your changes.
This PR adds a job to check the wheels in a minimal Windows Docker container.
Any other comments
Note that the base image in the Windows Dockerfile (
Windows) is minimal in the sense that it only installs Python from https://python.org (Step 7) andpipusing theget-pip.pyscript (Step 9). Using this minimal base image we install the corresponding Windows wheel and importsklearnfor checking DLL errors (#15899).CC @ogrisel and @thomasjpfan.