Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(backport): Add dev instructions and fix typos #2206

Merged
merged 6 commits into from
May 16, 2023
Merged

docs(backport): Add dev instructions and fix typos #2206

merged 6 commits into from
May 16, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 16, 2023 •
edited
Loading

Description

Backport components of:

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport components of:
   - PR https://github.com/scikit-hep/pyhf/pull/2046
   - PR https://github.com/scikit-hep/pyhf/pull/2098
   - PR https://github.com/scikit-hep/pyhf/pull/2113
   - PR https://github.com/scikit-hep/pyhf/pull/2115
   - PR https://github.com/scikit-hep/pyhf/pull/2145
   - PR https://github.com/scikit-hep/pyhf/pull/2198

@matthewfeickert matthewfeickert added docs Documentation related backport Backport PRs from main to release branch labels May 16, 2023
@matthewfeickert matthewfeickert self-assigned this May 16, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.7.x@aa683bf). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/v0.7.x    #2206   +/-   ##
=================================================
  Coverage                  ?   96.51%           
=================================================
  Files                     ?       69           
  Lines                     ?     4532           
  Branches                  ?      646           
=================================================
  Hits                      ?     4374           
  Misses                    ?      123           
  Partials                  ?       35
Flag Coverage Δ
unittests-3.10 96.31% <0.00%> (?)
unittests-3.7 96.29% <0.00%> (?)
unittests-3.9 96.35% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit 6e5feef into release/v0.7.x May 16, 2023
@matthewfeickert matthewfeickert deleted the docs/update-instructions branch May 16, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
backport Backport PRs from main to release branch docs Documentation related
Projects
No open projects
pyhf v0.7.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert