Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correct 'tensorflow' typo in v0.7.1 release notes #2198

Merged
merged 2 commits into from
May 11, 2023
Merged

docs: Correct 'tensorflow' typo in v0.7.1 release notes #2198

merged 2 commits into from
May 11, 2023

Conversation

matthewfeickert
Copy link
Member

Description

Fix 'tensorlfow' -> 'tensorflow' typ in the v0.7.1 release notes. 😬

pyhf/docs/release-notes/v0.7.1.rst

Line 12 in 5161749

* The ``tensorflow`` extra (``'pyhf[tensorlfow]'``) now automatically installs

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Fix 'tensorlfow' -> 'tensorflow'

@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix need-to-backport tmp label until can be backported to patch release branch labels May 11, 2023
@matthewfeickert matthewfeickert self-assigned this May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (5161749) 98.30% compared to head (ce10d81) 98.30%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2198   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4533     4533           
  Branches      801      801           
=======================================
  Hits         4456     4456           
  Misses         45       45           
  Partials       32       32
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.12% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 71fd076 into main May 11, 2023
@matthewfeickert matthewfeickert deleted the docs/fix-typo branch May 11, 2023 19:24
@matthewfeickert matthewfeickert mentioned this pull request May 16, 2023
Merged
4 tasks
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 16, 2023
matthewfeickert added a commit that referenced this pull request May 16, 2023
@matthewfeickert
docs(backport): Add dev instructions and fix typos (#2206)
6e5feef 
* Backport components of:
   - PR #2046
   - PR #2098
   - PR #2113
   - PR #2115
   - PR #2145
   - PR #2198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
docs Documentation related fix A bug fix
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert