Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Run CI and packaging workflows on release branch PRs #2149

Merged
merged 1 commit into from
Mar 31, 2023
Merged

ci: Run CI and packaging workflows on release branch PRs #2149

merged 1 commit into from
Mar 31, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 31, 2023 •
edited
Loading

Description

If a PR is made to a patch release branch run the CI and the publish package GitHub Action workflows.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* If a PR is made to a patch release branch run the CI and
  the publish package GitHub Action workflows.

@matthewfeickert
ci: Run CI and packaging workflows on release branch PRs
aea20fc 
* If a PR is made to a patch release branch run the CI and
  the publish package GitHub Action workflows.
@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions chore Other changes that don't modify src or test files labels Mar 31, 2023
@matthewfeickert matthewfeickert self-assigned this Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (28c6172) 98.16% compared to head (aea20fc) 98.30%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
+ Coverage   98.16%   98.30%   +0.13%     
==========================================
  Files          69       69              
  Lines        4531     4531              
  Branches      800      800              
==========================================
+ Hits         4448     4454       +6     
+ Misses         48       45       -3     
+ Partials       35       32       -3
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.15% <ø> (ø)
unittests-3.10 96.31% <ø> (?)
unittests-3.11 96.31% <ø> (?)
unittests-3.8 96.33% <ø> (?)
unittests-3.9 96.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit da5192a into main Mar 31, 2023
@matthewfeickert matthewfeickert deleted the ci/run-on-release-branches branch March 31, 2023 02:45
@matthewfeickert matthewfeickert mentioned this pull request Mar 31, 2023
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request Mar 31, 2023
@matthewfeickert
ci: Run CI and packaging workflows on release branch PRs (#2151)
b4fa0ee 
* Backport PR #2149 and add Docker build and docs workflows
  to run on PRs on patch release branches.
* Backport components of:
   - PR #2047
   - PR #2058
   - PR #2102
   - PR #2106
   - PR #2140
   - PR #2145
   - PR #2146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert