Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Python 3.11 to testing and default to using it #2145

Merged
merged 11 commits into from
Mar 23, 2023
Merged

feat: Add Python 3.11 to testing and default to using it #2145

merged 11 commits into from
Mar 23, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 23, 2023 •
edited
Loading

Description

Now that TensorFlow v2.12.0 is out with Python 3.11 support, add Python 3.11 to the testing in CI and then default all the uses of Python 3.10 in the project to Python 3.11.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add Python 3.11 to testing in CI.
* Default to using Python 3.11 in GitHub Actions where possible.
* Update to using Python 3.11 in linting and validation tools.
* Update Binder runtime Python to Python 3.11.
* Update Dockerfile base image to python:3.11-slim-bullseye.
* Update the docs to advocate using Python 3.11 for development.
* Add ignore of DeprecationWarning of Python's sre_constants from TensorFlow
   - c.f. https://docs.python.org/3.11/whatsnew/3.11.html#modules
     > Undocumented modules sre_compile, sre_constants and sre_parse
     > are now deprecated. (Contributed by Serhiy Storchaka in bpo-47152.)
* Add Python 3.11 trove classifier to PyPI metadata.

@matthewfeickert matthewfeickert added feat/enhancement New feature or request docs Documentation related labels Mar 23, 2023
@matthewfeickert matthewfeickert self-assigned this Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (c56a327) 98.30% compared to head (aaef56b) 98.30%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #2145    +/-   ##
========================================
  Coverage   98.30%   98.30%            
========================================
  Files          69       69            
  Lines        4531     4531            
  Branches      645      800   +155     
========================================
  Hits         4454     4454            
  Misses         45       45            
  Partials       32       32
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.15% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (?)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit 28c6172 into main Mar 23, 2023
@matthewfeickert matthewfeickert deleted the feat/add-python-3-11-to-ci branch March 23, 2023 16:59
@matthewfeickert matthewfeickert mentioned this pull request Mar 31, 2023
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request Mar 31, 2023
@matthewfeickert
build(backport): Switch to using Hatchling as build backend (#2148)
4c2cf30 
* Backport PR #2095 to the release/v0.7.x branch for easier comparisons.
* Also backport components of:
    - PR #2072
    - PR #2099
    - PR #2100
    - PR #2119
    - PR #2125
    - PR #2145
* In filterwarnings ignore all DeprecationWarning on patch release branches
  (e.g. release/v0.7.x).
@matthewfeickert matthewfeickert mentioned this pull request Mar 31, 2023
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request Mar 31, 2023
@matthewfeickert
ci: Run CI and packaging workflows on release branch PRs (#2151)
b4fa0ee 
* Backport PR #2149 and add Docker build and docs workflows
  to run on PRs on patch release branches.
* Backport components of:
   - PR #2047
   - PR #2058
   - PR #2102
   - PR #2106
   - PR #2140
   - PR #2145
   - PR #2146
This was referenced Apr 6, 2023
Merged
Merged
@matthewfeickert matthewfeickert mentioned this pull request May 16, 2023
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request May 16, 2023
@matthewfeickert
docs(backport): Add dev instructions and fix typos (#2206)
6e5feef 
* Backport components of:
   - PR #2046
   - PR #2098
   - PR #2113
   - PR #2115
   - PR #2145
   - PR #2198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratsg kratsg kratsg approved these changes

@lukasheinrich lukasheinrich Awaiting requested review from lukasheinrich

Assignees

@matthewfeickert matthewfeickert

Labels
docs Documentation related feat/enhancement New feature or request
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewfeickert @kratsg