Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update lower bound on tensorflow to v2.6.5 #1874

Merged
merged 3 commits into from
May 27, 2022
Merged

build: Update lower bound on tensorflow to v2.6.5 #1874

merged 3 commits into from
May 27, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 27, 2022 •
edited
Loading

Description

Amends PR #1869. Following Discussion #1871, bump tensorflow lower bound to the oldest supported version by the TensorFlow project following tensorflow/tensorflow#56077.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update lower bound on tensorflow to v2.6.5 as it is the "oldest" SemVer release
that is not broken on install by protobuf v4.21.0 ABI incompatibility.
   - c.f. https://github.com/tensorflow/tensorflow/issues/56077
   - Amend PR #1869
* Update tests/constraints.txt to use tensorflow==2.6.5.

@matthewfeickert matthewfeickert added the build Changes that affect the build system or external dependencies label May 27, 2022
@matthewfeickert matthewfeickert self-assigned this May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022 •
edited
Loading

Codecov Report

Merging #1874 (63c89c8) into master (ea3249a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4322     4322           
  Branches      726      726           
=======================================
  Hits         4243     4243           
  Misses         46       46           
  Partials       33       33
Flag Coverage Δ
contrib 26.39% <ø> (ø)
doctest 60.73% <ø> (ø)
unittests-3.10 96.04% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3249a...63c89c8. Read the comment docs.

@matthewfeickert
Copy link
Member Author

Thomas's advice in PR #1869 combined with @henryiii's comment #1871 (comment)

Anyway, on the other side, I'd generally argue that you should support only supported versions. It's a lot of extra technical debt to support unsupported versions of anything, and convincing a user to upgrade is likely easier than maintaining old support, and crippling the new features and optimizations you could otherwise add. Someone can always select an older PyHF if they are on an older tensorflow. Someone okay with an old tensorflow / python / etc should be okay with an older pyhf.

seem convincing to me to make this PR.

@matthewfeickert matthewfeickert merged commit 3675565 into master May 27, 2022
@matthewfeickert matthewfeickert deleted the build/update-tensorflow-lower-bound branch May 27, 2022 18:15
@matthewfeickert matthewfeickert added the dependencies Pull requests that update a dependency file label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratsg kratsg kratsg approved these changes

@lukasheinrich lukasheinrich Awaiting requested review from lukasheinrich

Assignees

@matthewfeickert matthewfeickert

Labels
build Changes that affect the build system or external dependencies dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewfeickert @kratsg