Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Ignore EPJ Web of Conferences DOI URLs during Sphinx linkcheck #1870

Merged
merged 2 commits into from
May 26, 2022
Merged

test: Ignore EPJ Web of Conferences DOI URLs during Sphinx linkcheck #1870

merged 2 commits into from
May 26, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 26, 2022 •
edited
Loading

Description

DOI URLs for EPJ Web of Conferences proceedings will periodically fail to resolve given '500 Server Error' as the result of EPJ backend problems.

Example:

(       citations: line   25) broken    https://doi.org/10.1051/epjconf/202024506017 - 500 Server Error: Internal Server Error for url: https://www.epj-conferences.org/10.1051/epjconf/202024506017
(           index: line  309) ok        https://github.com/scikit-hep/pyhf/pull/1000
(   release-notes: line   19) ok        https://github.com/scikit-hep/pyhf/pull/1001
(       citations: line   25) broken    https://doi.org/10.1051/epjconf/20212[510](https://github.com/scikit-hep/pyhf/runs/6603171789?check_suite_focus=true#step:7:511)2070 - 500 Server Error: Internal Server Error for url: https://www.epj-conferences.org/10.1051/epjconf/202125102070
(   release-notes: line   45) ok        https://github.com/scikit-hep/pyhf/pull/1369
(   release-notes: line   17) ok        https://github.com/scikit-hep/pyhf/pull/1382
(   release-notes: line   73) ok        https://github.com/scikit-hep/pyhf/pull/1377
(       citations: line   25) broken    https://doi.org/10.1051/epjconf/202125103067 - 500 Server Error: Internal Server Error for url: https://www.epj-conferences.org/10.1051/epjconf/202125103067

epj-error

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Ignore DOI URLs for EPJ Web of Conferences from Sphinx linkcheck tests as the DOI
URLs will periodically fail to resolve given '500 Server Error' as the result of
EPJ backend problems.

@matthewfeickert matthewfeickert added docs Documentation related tests pytest labels May 26, 2022
@matthewfeickert matthewfeickert self-assigned this May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #1870 (45e0e3c) into master (45e0e3c) will not change coverage.
The diff coverage is n/a.

❗ Current head 45e0e3c differs from pull request most recent head 292561d. Consider uploading reports for the commit 292561d to get more accurate results

@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4322     4322           
  Branches      726      726           
=======================================
  Hits         4243     4243           
  Misses         46       46           
  Partials       33       33
Flag Coverage Δ
contrib 26.39% <0.00%> (ø)
doctest 60.73% <0.00%> (ø)
unittests-3.10 96.04% <0.00%> (ø)
unittests-3.7 96.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e0e3c...292561d. Read the comment docs.

@matthewfeickert
Copy link
Member Author

I'm just going to merge this once CI passes as PR #1866 was basically the same thing and was approved.

@matthewfeickert
test: Ignore EPJ Web of Conferences DOI URLs during Sphinx linkcheck
3f6bf79
@matthewfeickert
Add comment
292561d 
* DOI URLs for EPJ Web of Conferences proceedings will periodically fail
to resolve given '500 Server Error' as the result of EPJ backend problems.
@matthewfeickert matthewfeickert force-pushed the docs/avoid-epjconf-dois branch from 5dc85d3 to 292561d Compare May 26, 2022 02:49
@matthewfeickert matthewfeickert merged commit 031218c into master May 26, 2022
@matthewfeickert matthewfeickert deleted the docs/avoid-epjconf-dois branch May 26, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
docs Documentation related tests pytest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert