Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restrict iminuit to compatible releases below 2.4.0 #1307

Merged
merged 2 commits into from
Feb 11, 2021
Merged

fix: Restrict iminuit to compatible releases below 2.4.0 #1307

merged 2 commits into from
Feb 11, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 11, 2021 •
edited
Loading

Description

Temporary resolution to Issue #1305

In the interest of getting v0.6.0 released in a timely manner, bound iminuit releases to be below v2.4.0 until the behavior in PR #1306 can be better understood. Aim to have this understood and acted on for pyhf v0.6.1.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Restrict iminuit to compatible releases below v2.4.0
   - c.f. https://github.com/scikit-hep/pyhf/issues/1305

@matthewfeickert matthewfeickert added the fix A bug fix label Feb 11, 2021
@matthewfeickert matthewfeickert self-assigned this Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021 •
edited
Loading

Codecov Report

Merging #1307 (618d458) into master (9d56349) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          63       63           
  Lines        3749     3749           
  Branches      535      535           
=======================================
  Hits         3655     3655           
  Misses         55       55           
  Partials       39       39
Flag Coverage Δ
unittests 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc32a69...618d458. Read the comment docs.

@matthewfeickert matthewfeickert merged commit d6544a8 into master Feb 11, 2021
@matthewfeickert matthewfeickert deleted the fix/pin-iminuit branch February 11, 2021 21:52
@matthewfeickert
Copy link
Member Author

cc @alexander-held

@alexander-held alexander-held mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasheinrich lukasheinrich lukasheinrich approved these changes

@kratsg kratsg kratsg approved these changes

Assignees

@matthewfeickert matthewfeickert

Labels
fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewfeickert @kratsg @lukasheinrich