Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate contrib download to contrib module #1119

Merged
merged 7 commits into from
Oct 16, 2020
Merged

refactor: Migrate contrib download to contrib module #1119

merged 7 commits into from
Oct 16, 2020

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 15, 2020 •
edited
Loading

Description

Resolves #1117

This PR keeps all the contrib code located under a single contrib module to make it easier to move out and refactor.

ReadTheDocs build:

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Migrate contrib download code from cli module to contrib module
   - Unify all of the contrib code in a single contrib module for easier factoring out and bookkeeping
* Use DOI URL for all contrib download docstring examples
* Amends PR #1046

@matthewfeickert matthewfeickert added refactor A code change that neither fixes a bug nor adds a feature contrib Targeting pyhf.contrib and not the core of pyhf labels Oct 15, 2020
@matthewfeickert matthewfeickert self-assigned this Oct 15, 2020
@matthewfeickert matthewfeickert added the docs Documentation related label Oct 15, 2020
@matthewfeickert matthewfeickert marked this pull request as ready for review October 15, 2020 23:34
@codecov
Copy link

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #1119 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1119   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          62       62           
  Lines        3570     3571    +1     
  Branches      513      513           
=======================================
+ Hits         3459     3460    +1     
  Misses         68       68           
  Partials       43       43
Impacted Files Coverage Δ
src/pyhf/cli/__init__.py 100.00% <ø> (ø)
src/pyhf/cli/cli.py 100.00% <ø> (ø)
src/pyhf/contrib/cli.py 100.00% <ø> (ø)
src/pyhf/contrib/utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe4ebd...2579b25. Read the comment docs.

@kratsg kratsg merged commit bdb6466 into master Oct 16, 2020
@kratsg kratsg deleted the refactor/move-all-download-to-contrib branch October 16, 2020 02:45
@matthewfeickert matthewfeickert mentioned this pull request Oct 16, 2020
Closed
6 tasks
@matthewfeickert matthewfeickert mentioned this pull request Dec 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasheinrich lukasheinrich lukasheinrich approved these changes

@kratsg kratsg kratsg approved these changes

Assignees

@matthewfeickert matthewfeickert

Labels
contrib Targeting pyhf.contrib and not the core of pyhf docs Documentation related refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move cli/contrib.py to contrib/cli.py
3 participants
@matthewfeickert @kratsg @lukasheinrich