Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify warning for shapesys (and staterror) in documentation #1717

Closed
1 task done
kratsg opened this issue Dec 2, 2021 · 0 comments · Fixed by #1740
Closed
1 task done

Clarify warning for shapesys (and staterror) in documentation #1717

kratsg opened this issue Dec 2, 2021 · 0 comments · Fixed by #1740
Assignees
@matthewfeickert
Labels
docs Documentation related needs-triage Needs a maintainer to categorize and assign

Comments

@kratsg
Copy link
Contributor

kratsg commented Dec 2, 2021

Summary

The shapesys documentation indicates we don't allocate NPs for zero-valued entries -- but this changed as of #1639.

Documentation Page Link

https://scikit-hep.org/pyhf/likelihood.html#uncorrelated-shape-shapesys

Code of Conduct

  • I agree to follow the Code of Conduct
@kratsg kratsg added docs Documentation related needs-triage Needs a maintainer to categorize and assign labels Dec 2, 2021
@matthewfeickert matthewfeickert mentioned this issue Dec 24, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewfeickert matthewfeickert

Labels
docs Documentation related needs-triage Needs a maintainer to categorize and assign
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Note shapesys and staterror modifier set to 1 for modifier data of 0 scikit-hep/pyhf
2 participants
@kratsg @matthewfeickert