Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for sunos #983

Merged
merged 2 commits into from
May 17, 2023
Merged

fix: add support for sunos #983

merged 2 commits into from
May 17, 2023

Conversation

mtelka
Copy link
Contributor

@mtelka mtelka commented May 17, 2023

Fixes #520

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #983 (3ac336b) into main (b53bd6b) will increase coverage by 0.03%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #983      +/-   ##
==========================================
+ Coverage   86.19%   86.23%   +0.03%     
==========================================
  Files          31       32       +1     
  Lines        1565     1576      +11     
  Branches      344      347       +3     
==========================================
+ Hits         1349     1359      +10     
- Misses        153      154       +1     
  Partials       63       63              
Impacted Files Coverage Δ
skbuild/platform_specifics/sunos.py 87.50% <87.50%> (ø)
skbuild/platform_specifics/platform_factory.py 100.00% <100.00%> (ø)

@henryiii henryiii merged commit f2d253e into scikit-build:main May 17, 2023
@jimhall
Copy link

jimhall commented May 17, 2023

👍 Thanks so much

@mtelka mtelka deleted the sunos branch May 17, 2023 15:35
@henryiii
Copy link
Contributor

Thank you! I’m going to have to take your word for it that it works. :) (Though looks like there may be a GHA that will set up a VM for some of these operating systems.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask for Solaris or illumos support
3 participants