Revert "fix: avoid 'not found' warning if libs are not found (#960)" #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build#960)" This reverts commit 8ee16a0.
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
=======================================
Coverage 86.18% 86.18%
=======================================
Files 31 31
Lines 1564 1564
Branches 344 344
=======================================
Hits 1348 1348
Misses 153 153
Partials 63 63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8ee16a0.
This was to hide the warning, but
PYTHON_INCLUDE_DIRSwas not getting set fromPYTHON_INCLUDE_DIR, and it caused breakages when used outside of SKBUILD. Fixes #963.