Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid 'not found' warning if libs are not found #960

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

henryiii
Copy link
Contributor

Fixing one warning that can show up, mentioned in #959, simi-followup to #940.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #960 (483a305) into main (0c0fc61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files          31       31           
  Lines        1564     1564           
  Branches      344      344           
=======================================
  Hits         1348     1348           
  Misses        153      153           
  Partials       63       63           

@henryiii henryiii merged commit 8ee16a0 into main Apr 28, 2023
@henryiii henryiii deleted the henryiii/fix/warnlib branch April 28, 2023 01:24
henryiii added a commit to henryiii/scikit-build that referenced this pull request May 1, 2023
henryiii added a commit that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant