tests: custom venv tester #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/tests/customvenv
branch
3 times, most recently
from
df09dd9 to
4435ef2
Compare
henryiii
force-pushed
the
henryiii/tests/customvenv
branch
from
6a000e3 to
b5e6d78
Compare
henryiii
force-pushed
the
henryiii/tests/customvenv
branch
from
b5e6d78 to
0312dc9
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/tests/customvenv
branch
from
5020a23 to
e40d84b
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/tests/customvenv
branch
from
0ea77f2 to
49a57dc
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/tests/customvenv
branch
from
39aeb0d to
5b2b7b6
Compare
henryiii
commented
May 30, 2023
henryiii
commented
May 30, 2023
| @@ -394,7 +394,7 @@ def setup( | |||
| cmake_process_manifest_hook: Callable[[list[str]], list[str]] | None = None, | |||
| cmake_install_target: str = "install", | |||
| **kw: Any, | |||
| ) -> None: | |||
| ) -> upstream_Distribution: | |||
There was a problem hiding this comment.
This is technically incorrect in typeshed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping usage of pytest-virtualenv, which is not well maintained and doesn't work everywhere.
Ignores warnings from Python 3.12 + PyTest.
Fixing coverage, which was sometimes ending up being incorrectly configured.
Also improving static checks (mypy now runs, albeit less strictly, on the tests folder), which potentially improves a couple of tests.
The
isolatedmarker is used for all isolated checks - test_distribution is an isolated check.