fix: avoid forcing the macOS version #607
Conversation
henryiii
force-pushed
the
henryiii/fix/macos
branch
from
96ae1a2 to
1eaadf9
Compare
henryiii
force-pushed
the
henryiii/fix/macos
branch
from
1eaadf9 to
6b8244e
Compare
|
Before: $ MACOSX_DEPLOYMENT_TARGET=10.13 _PYTHON_HOST_PLATFORM=macosx-10.11-universal2 pipx run build --wheel
...
Successfully built scikit_build_example-0.0.1-cp310-cp310-macosx_10_11_universal2.whlAfter: $ MACOSX_DEPLOYMENT_TARGET=10.13 _PYTHON_HOST_PLATFORM=macosx-10.11-universal2 pipx run build --wheel
...
Successfully built scikit_build_example-0.0.1-cp310-cp310-macosx_10_13_universal2.whlI'm happy with it! :) |
|
Ouch, this bites PyPy because it defaults to 10.7, instead of an actual proper minimum (10.9+). @mattip I'm sure I've mentioned this before - do you know if there's been any progress on that (or where we discussed it before)? Setuptools (and therefore Scikit-Build) require I'm still in favor of this patch since it's exactly the same issue with exactly the same fix as vanilla setuptools, but it would be nice to fix it properly in PyPy. We could also consider setting |
|
This will be 10.9 for the upcoming release. |
This fixes #596 by removing the custom logic that is lowering the macOS version incorrectly. This was originally there because Python defaults to whatever it was built with, and 10.6 was too low for modern macOS. However, all normal Pythons (everything except the dead 3.5) have 10.9 or better installers now, and this is causing the (correct) calculation of the version to be lost. Users should always set
MACOSX_DEPLOYMENT_TARGET, and most wheel building tools will do this for you just in case.Draft until I'm sure it works or can add tests.