Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up pylint #1017

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

henryiii
Copy link
Contributor

Make sure it's fully passing.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.19%. Comparing base (9fb550b) to head (dcd2e79).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
skbuild/platform_specifics/cygwin.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files          32       32           
  Lines        1579     1579           
  Branches      350      351    +1     
=======================================
  Hits         1361     1361           
  Misses        155      155           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 08aa7ca into scikit-build:main Jul 25, 2023
@henryiii henryiii deleted the henryiii/chore/fixpylint branch July 25, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant