chore: remove pkg_resources and test command #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
henryiii
commented
Jul 21, 2023
henryiii
commented
- fix: drop pkg_resources
- fix: drop custom test command
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/pkg_res
branch
from
867b771 to
dde5e79
Compare
henryiii
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
- Coverage 86.26% 86.19% -0.07%
==========================================
Files 33 32 -1
Lines 1587 1579 -8
Branches 350 350
==========================================
- Hits 1369 1361 -8
Misses 155 155
Partials 63 63 ☔ View full report in Codecov by Sentry. |
jcfr
reviewed
Jul 21, 2023
| @@ -225,10 +224,6 @@ def execute_setup_py(project_dir, setup_args, disable_languages_test=False): | |||
| del os.environ["_PYTHON_HOST_PLATFORM"] | |||
|
|
|||
| with push_dir(str(project_dir)), push_argv(["setup.py", *setup_args]), prepend_sys_path([str(project_dir)]): | |||
| # Restore master working set that is reset following call to "python setup.py test" | |||
| # See function "project_on_sys_path()" in setuptools.command.test | |||
| pkg_resources._initialize_master_working_set() # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
Glad to see this one go 🚀 ... if i recall it was not easy to find out at that time.
jcfr
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.