-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model_type_pahm
parameter support
#62
Conversation
@@ -334,7 +334,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): | |||
if not is_within_directory(path, member_path): | |||
raise Exception("Attempted Path Traversal in Tar File") | |||
|
|||
tar.extractall(path, members, numeric_owner) | |||
tar.extractall(path, members, numeric_owner=numeric_owner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numeric_owner
is a keyword-only argument
@cuill thanks for merging. Would it be possible that you please create a new release from the latest code as well? |
@SorooshMani-NOAA done |
@SorooshMani-NOAA Thank you! |
@yunfangsun when creating meteo = BestTrackForcing(..., hurricane_model="symmetric", ...) |
Hi @SorooshMani-NOAA
|
@yunfangsun you need to have version |
Add `model_type_pahm` parameter support
Fix #63
Fix #61
Recently a new parameter was introduced in
param.nml
in90a67ff
. This will control what model is used by integrated PaHM code, GAHM:10
vs Symmetric:1