feat(baremetal): add create server with type #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 12, 2020
QuentinBrosse
suggested changes
Mar 13, 2020
loicbourgois
suggested changes
Mar 13, 2020
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
remyleone
force-pushed
the
create_server
branch
from
76a3adf to
fa4edc4
Compare
golangcibot
reviewed
Mar 17, 2020
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
remyleone
force-pushed
the
create_server
branch
from
59dfff3 to
02eb4f1
Compare
golangcibot
reviewed
Mar 19, 2020
remyleone
force-pushed
the
create_server
branch
2 times, most recently
from
219b11b to
5fa5540
Compare
remyleone
changed the title
loicbourgois
changed the title
loicbourgois
suggested changes
Mar 19, 2020
cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden
Outdated
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden
Outdated
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden
Outdated
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-baremetal-server-usage.stderr.golden
Outdated
Show resolved
Hide resolved
...emetal/v1alpha1/testdata/test-create-server-errors-error-invalid-instance-type.stderr.golden
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/testdata/test-list-server-list-with-tags.stdout.golden
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/testdata/test-list-server-simple.stdout.golden
Outdated
Show resolved
Hide resolved
golangcibot
reviewed
Mar 20, 2020
remyleone
force-pushed
the
create_server
branch
from
12f0510 to
7a336d6
Compare
golangcibot
reviewed
Mar 26, 2020
loicbourgois
suggested changes
Mar 27, 2020
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
loicbourgois
previously requested changes
Mar 27, 2020
QuentinBrosse
suggested changes
Mar 27, 2020
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
remyleone
force-pushed
the
create_server
branch
from
3158ad1 to
91b18be
Compare
jerome-quere
suggested changes
Mar 30, 2020
cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Outdated
Show resolved
Hide resolved
kindermoumoute
requested changes
Apr 1, 2020
kindermoumoute
approved these changes
Apr 2, 2020
remyleone
added
the
elastic-metal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.