feat(k8s): add kubeconfig commands #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-quere
previously requested changes
Mar 10, 2020
Sh4d1
force-pushed
the
k8s_kubeconfig
branch
3 times, most recently
from
6d525e1 to
f68a203
Compare
golangcibot
reviewed
Mar 14, 2020
internal/namespaces/k8s/v1beta4/custom_kubeconfig_uninstall_test.go
Outdated
Show resolved
Hide resolved
golangcibot
reviewed
Mar 14, 2020
internal/namespaces/k8s/v1beta4/custom_kubeconfig_uninstall_test.go
Outdated
Show resolved
Hide resolved
|
Tests failing will be resolved by #772 |
Sh4d1
force-pushed
the
k8s_kubeconfig
branch
4 times, most recently
from
36b8c8e to
ea20f24
Compare
|
@jerome-quere good to go for me |
remyleone
reviewed
Mar 16, 2020
remyleone
reviewed
Mar 16, 2020
remyleone
reviewed
Mar 16, 2020
remyleone
reviewed
Mar 16, 2020
remyleone
reviewed
Mar 16, 2020
internal/namespaces/k8s/v1beta4/custom_kubeconfig_install_test.go
Outdated
Show resolved
Hide resolved
remyleone
reviewed
Mar 16, 2020
internal/namespaces/k8s/v1beta4/custom_kubeconfig_install_test.go
Outdated
Show resolved
Hide resolved
remyleone
reviewed
Mar 16, 2020
internal/namespaces/k8s/v1beta4/custom_kubeconfig_install_test.go
Outdated
Show resolved
Hide resolved
remyleone
reviewed
Mar 16, 2020
remyleone
reviewed
Mar 16, 2020
remyleone
previously approved these changes
Mar 16, 2020
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
loicbourgois
suggested changes
Mar 17, 2020
cmd/scw/testdata/test-all-usage-k8s-kubeconfig-get-usage.stderr.golden
Outdated
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-k8s-kubeconfig-install-usage.stderr.golden
Outdated
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-k8s-kubeconfig-uninstall-usage.stderr.golden
Outdated
Show resolved
Hide resolved
internal/namespaces/k8s/v1beta4/custom_kubeconfig_install_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/k8s/v1beta4/testdata/test-uninstall-kubeconfig-empty-file.stdout.golden
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
loicbourgois
suggested changes
Mar 18, 2020
cmd/scw/testdata/test-all-usage-k8s-kubeconfig-install-usage.stderr.golden
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-k8s-kubeconfig-install-usage.stderr.golden
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-k8s-kubeconfig-uninstall-usage.stderr.golden
Show resolved
Hide resolved
internal/namespaces/k8s/v1beta4/custom_kubeconfig_install_test.go
Outdated
Show resolved
Hide resolved
internal/namespaces/k8s/v1beta4/testdata/test-uninstall-kubeconfig-empty-file.stdout.golden
Outdated
Show resolved
Hide resolved
Co-Authored-By: Loïc Bourgois <loic@bourgois.pro>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
loicbourgois
suggested changes
Mar 18, 2020
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
clement-gilbert
pushed a commit
to clement-gilbert/scaleway-cli
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be merged after
#753#752and#751in order to pass the testsSigned-off-by: Patrik Cyvoct pcyvoct@scaleway.com