Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): handle display oneof #3728

Merged
merged 6 commits into from
Apr 5, 2024
Merged

feat(core): handle display oneof #3728

merged 6 commits into from
Apr 5, 2024

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Mar 28, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@jremy42 jremy42 self-assigned this Apr 2, 2024
@jremy42 jremy42 force-pushed the feat/handle-display-oneof branch from da33898 to 47f2278 Compare April 3, 2024 08:54
@jremy42 jremy42 marked this pull request as ready for review April 3, 2024 14:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 77.12%. Comparing base (5bf53e0) to head (8418fe4).
Report is 10 commits behind head on master.

Files Patch % Lines
internal/core/cobra_usage_builder.go 35.71% 7 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3728      +/-   ##
==========================================
+ Coverage   75.45%   77.12%   +1.66%     
==========================================
  Files         202      202              
  Lines       44323    37131    -7192     
==========================================
- Hits        33444    28637    -4807     
+ Misses       9653     7266    -2387     
- Partials     1226     1228       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 changed the title feat(core):handle display oneof feat(core): handle display oneof Apr 5, 2024
@remyleone remyleone added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@remyleone remyleone added this pull request to the merge queue Apr 5, 2024
@remyleone remyleone removed this pull request from the merge queue due to a manual request Apr 5, 2024
@remyleone remyleone added this pull request to the merge queue Apr 5, 2024
Merged via the queue into scaleway:master with commit c16e24e Apr 5, 2024
12 checks passed
jremy42 added a commit to jremy42/scaleway-cli that referenced this pull request Apr 8, 2024
@jremy42
feat(core): handle display oneof (scaleway#3728)
27f1852
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 16, 2024
@jremy42 @Laure-di
feat(core): handle display oneof (scaleway#3728)
c0d017e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@jremy42 jremy42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jremy42 @codecov-commenter @remyleone