Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add support for template output #1360

Merged
merged 9 commits into from
Sep 1, 2020
Merged

feat(core): add support for template output #1360

merged 9 commits into from
Sep 1, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@remyleone remyleone marked this pull request as draft August 25, 2020 16:11
@remyleone remyleone marked this pull request as ready for review August 27, 2020 14:56
@remyleone remyleone linked an issue Aug 27, 2020 that may be closed by this pull request
Add support for templated output #1062
Closed
kindermoumoute
kindermoumoute requested changes Sep 1, 2020
View reviewed changes
internal/core/autocomplete.go Outdated Show resolved Hide resolved
internal/core/printer.go Show resolved Hide resolved
internal/core/printer.go Outdated Show resolved Hide resolved
internal/core/printer.go Outdated Show resolved Hide resolved
internal/core/printer.go Outdated Show resolved Hide resolved
internal/core/testdata/test-core-printer-human-list-with-options-unknown-column.golden Outdated Show resolved Hide resolved
internal/core/testdata/test-template-printer-template-list-with-options-unknown-column.golden Show resolved Hide resolved
internal/core/testdata/test-template-printer-template-list-with-options.golden Show resolved Hide resolved
remyleone and others added 4 commits September 1, 2020 15:47
@remyleone @kindermoumoute
Update internal/core/printer.go
efa724f 
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
@remyleone
Fix nits
e69788e
@remyleone
Fix
28a4971
@remyleone
Fix
0c328f7
kindermoumoute
kindermoumoute approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit e7318b3 into scaleway:master Sep 1, 2020
@remyleone remyleone deleted the template_output branch September 1, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere left review comments

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for templated output
3 participants
@remyleone @jerome-quere @kindermoumoute