-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the sample applications to be able to build with Java 21 #71
Conversation
Regarding d1f68f1, all I did is only the following:
Other differences were automatically generated when executing the gradle command. |
I've confirmed that the all samples are able to build with Java 21. I've also confirmed that I can run/try microservice-transaction-sample and spring-data-microservice-transaction-sample following their documents. |
@KodaiD So, unlike the ScalarDL samples, we don't need to use Toolchain in the ScalarDB samples. Is my understanding correct? If yes, what’s the difference? |
@brfrn169 Strictly speaking, we don't need to use the toolchain in both the ScalarDB sample and ScalarDL sample. But, in the update of ScalarDL sample, I tried to remove all warnings appearing when we built it. sourceCompatibility and targetCompatibility seem to be deprecated, and the following error appears when building.
Of course I can fix the sample to use the toolchain instead, but I think this it's outside the scope of this PR (I think the main target of this PR is making the sample to be able to build on Java 21). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@KodaiD Thank you for answering my question.
I think we should fix the samples to use the toolchain for consistency. Let's do that in a separate PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
FYI: I didn't test all samples, but I was able to run the ./gradlew docker
command under the spring-data-microservice-transaction-sample/
directory by using Java 8, 11, 17, and 21 in my local environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
Our sample applications should be able to built with the Java versions we support (Java 8, 11, 17, 21).
As a result of PR #70, our examples now work with Java 8, 11 and 17. However, most ScalarDB sample applications use Gradle 7.6 that does not support Java 21.
To address this issue, I try to upgrade the version of Gradle to 8.5 in this PR. I also try to eliminate the docker plugin that is not compatible with all Java versions we support.
Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A