Automatically format source code with pre-commit #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komamitsu
force-pushed
the
git-commit-hook-to-format
branch
from
73c1cfe to
55846f7
Compare
komamitsu
changed the title
brfrn169
reviewed
Jan 31, 2023
| @@ -62,6 +62,20 @@ Here are the contributors we are especially thankful for: | |||
| - [Toshihiro Suzuki](https://github.com/brfrn169) - created [Phoenix adapter](https://github.com/scalar-labs/scalardb-phoenix) for ScalarDB | |||
| - [Yonezawa-T2](https://github.com/Yonezawa-T2) - reported bugs around Serializable and proposed a new Serializable strategy (now named Extra-Read) | |||
|
|
|||
| ## Development | |||
There was a problem hiding this comment.
We should apply the same change to docs/index.md as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalarDB developers execute
gradlew spotlessApplyor IDE code formatter manually as a part of development. But the manual operation should be automated and documented for new contributors. This PR describes how to setup the automated operation. The drawback is every commit invokesgradlew spotlessand it would increase the latency of commit a bit (especially for the first invocation of Gradle daemon.)