Add method to retrieve the namespace names for the Dynamo Admin #679
Conversation
Torch3333
force-pushed
the
add_get_namespace_names_to_dynamo_admin
branch
4 times, most recently
from
231c721 to
02bd289
Compare
Torch3333
force-pushed
the
add_get_namespace_names_to_dynamo_admin
branch
from
02bd289 to
0153c23
Compare
| } | ||
| } | ||
|
|
||
| private void dropAllTableOfNamespace(Namespace namespace) throws ExecutionException { |
There was a problem hiding this comment.
| private void dropAllTableOfNamespace(Namespace namespace) throws ExecutionException { | |
| private void dropAllTablesOfNamespace(Namespace namespace) throws ExecutionException { |
There was a problem hiding this comment.
Thank you, I applied it.
| } catch (ConditionalCheckFailedException e) { | ||
| throw new ExecutionException( | ||
| "the namespace " + namespace + " cannot be created as it already exists"); | ||
| } |
There was a problem hiding this comment.
We should also handle other runtime exceptions here?
| } | |
| } catch (Exception e) { | |
| ... | |
| } |
There was a problem hiding this comment.
Thank you. I revised it, please have a look again.
| throw new ExecutionException( | ||
| "dropping the namespace " | ||
| + Namespace.of(namespacePrefix, nonPrefixedNamespace) | ||
| + " failed", | ||
| e); |
There was a problem hiding this comment.
It looks like this can throw a ExecutionException whose cause is also ExecutionException?
There was a problem hiding this comment.
Yes, I do this to give more context to the ExecutionException thrown by a sub-method. I think the stack trace produced makes it easier to understand the root reason for the error.
…_namespace_names_to_dynamo_admin
|
I changed the PR target branch to the feat/namespaces_management branch that will contain all the namespaces management-related changes. @brfrn169 Sorry for the trouble. Please have a look again. @feeblefakie It seems your review is not required since I did not push anything since your last review but feel free to have a look again. |
Torch3333
added
backward-incompatible
and removed
enhancement
This implement the
admin.getNamespaceNames()for the DynamoAdmin.