Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metadata cache expiration time configuration name #539

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Mar 31, 2022

This PR renames the metadata cache expiration time configuration name scalar.db.table_metadata.cache_expiration_time_secs to scalar.db.metadata.cache_expiration_time_secs to make it more general name. Since this configuration is only in the source code and it's not exposed in any documentation, I think it's no problem to change it. Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie March 31, 2022 07:54
@brfrn169 brfrn169 self-assigned this Mar 31, 2022
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 6bf9d72 into master Apr 4, 2022
@brfrn169 brfrn169 deleted the rename-metadata-cache-expiration-time-conf-name branch April 4, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants