Add support for isNull and isNotNull conditions #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
commented
Mar 22, 2022
Comment on lines
+343
to
+344
| IS_NULL, | ||
| IS_NOT_NULL |
There was a problem hiding this comment.
Added the new operators, IS_NULL and IS_NOT_NULL.
Comment on lines
+84
to
+85
| .compareTrueFirst(hasNullValue(), o.hasNullValue()) | ||
| .compare(getBigIntValue(), o.getBigIntValue()) |
There was a problem hiding this comment.
I made small changes for the compareTo methods of XXXColumn in this PR.
feeblefakie
approved these changes
Mar 25, 2022
| * | ||
| * @author Yuji Ito | ||
| */ | ||
| @NotThreadSafe | ||
| public final class ValueBinder implements ValueVisitor { | ||
| public final class ValueBinder implements ColumnVisitor { |
There was a problem hiding this comment.
Are these intended changes for this PR? (looks like coming from a previous PR or it's left unchanged in the previous PR?)
There was a problem hiding this comment.
Thank you for taking at this PR!
In the previous PR, I didn't remove all the usages of ValueVisitor, and I thought I was going to do that in another PR. But the changes were needed for this isNull and isNotNull conditions support, so I did it in this PR. I will remove the rest of the usages of ValueVisitor in another PR. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support for
isNullandisNotNullconditions for conditional mutations.We can specify
isNullandisNotNullconditions as follows:Please take a look!