Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reusable vulnerability check workflow #2288

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Use reusable vulnerability check workflow #2288

merged 3 commits into from
Oct 25, 2024

Conversation

ymorimo
Copy link
Contributor

@ymorimo ymorimo commented Oct 18, 2024 •
edited
Loading

Description

This PR changes to use the reusable vuln-check workflow (scalar-labs/actions#9).

Related issues and/or PRs

Changes made

  • Replaced the vulnerability checking job In vuln-check.yaml file with a reusable workflow call.
  • Removed scripts in ci/vuln-check/
  • No changes in manual-vuln-check.yaml and scheduled-vuln-check.yaml

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Used the new reusable vulnerability check workflow.

@ymorimo ymorimo self-assigned this Oct 18, 2024
@ymorimo ymorimo mentioned this pull request Oct 18, 2024
Merged
6 tasks
komamitsu
komamitsu approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

jnmt
jnmt approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@feeblefakie feeblefakie requested a review from brfrn169 October 23, 2024 01:59
feeblefakie
feeblefakie approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

brfrn169
brfrn169 reviewed Oct 24, 2024
View reviewed changes
.github/workflows/vuln-check.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to keep this file vuln-check.yaml? Can we use the reusable vulnerability check workflow scalar-labs/actions/.github/workflows/vuln-check-reusable.yaml@main directly in manual-vuln-check.yaml and scheduled-vuln-check.yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the vuln-check.yaml file has only the functionality to not duplicate the with: block. It has several repository-specific default values.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Thanks!

brfrn169
brfrn169 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Torch3333
Torch3333 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brfrn169 brfrn169 added the github_actions Pull requests that update GitHub Actions code label Oct 25, 2024
@brfrn169 brfrn169 merged commit de679ca into master Oct 25, 2024
46 checks passed
@brfrn169 brfrn169 deleted the vuln-check-reusable branch October 25, 2024 02:06
feeblefakie pushed a commit that referenced this pull request Oct 25, 2024
@ymorimo
Use reusable vulnerability check workflow (#2288)
fe3d2f4
@feeblefakie feeblefakie mentioned this pull request Oct 25, 2024
Merged
feeblefakie pushed a commit that referenced this pull request Oct 25, 2024
@ymorimo
Use reusable vulnerability check workflow (#2288)
ce047ed
This was referenced Oct 25, 2024
Merged
Merged
Merged
Merged
Merged
brfrn169 pushed a commit that referenced this pull request Oct 25, 2024
@ymorimo @brfrn169
Use reusable vulnerability check workflow (#2288)
11792cd
brfrn169 pushed a commit that referenced this pull request Oct 25, 2024
@ymorimo @brfrn169
Use reusable vulnerability check workflow (#2288)
5dc7d48
brfrn169 pushed a commit that referenced this pull request Oct 25, 2024
@ymorimo @brfrn169
Use reusable vulnerability check workflow (#2288)
c071c61
brfrn169 pushed a commit that referenced this pull request Oct 25, 2024
@ymorimo @brfrn169
Use reusable vulnerability check workflow (#2288)
2f277ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnmt jnmt jnmt approved these changes

@Torch3333 Torch3333 Torch3333 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@ymorimo ymorimo

Labels
github_actions Pull requests that update GitHub Actions code improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ymorimo @komamitsu @brfrn169 @feeblefakie @Torch3333 @jnmt