Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor KeyBytesEncoder to use ColumnVisitor #2270

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Refactor KeyBytesEncoder to use ColumnVisitor #2270

merged 2 commits into from
Oct 9, 2024

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Oct 2, 2024 •
edited
Loading

Description

This refactor the Dynamo adapter KeyBytesEncoder and related classes to use the ColumnVisitor instead of the deprecated ValueVisitor.

Related issues and/or PRs

N/A

Changes made

Refactor the KeybyteEncoder to use the ColumnVisitor.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@Torch3333 Torch3333 self-assigned this Oct 2, 2024
@Torch3333 Torch3333 force-pushed the refactor_keybitesencoder branch from c988a99 to 12ca9ba Compare October 2, 2024 06:36
@Torch3333 Torch3333 marked this pull request as ready for review October 3, 2024 05:05
komamitsu
komamitsu approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

feeblefakie
feeblefakie approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

brfrn169
brfrn169 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit d1adea6 into master Oct 9, 2024
46 checks passed
@brfrn169 brfrn169 deleted the refactor_keybitesencoder branch October 9, 2024 05:33
feeblefakie pushed a commit that referenced this pull request Oct 9, 2024
@Torch3333
Refactor KeyBytesEncoder to use ColumnVisitor (#2270)
b791742
@feeblefakie feeblefakie mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@Torch3333 Torch3333

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Torch3333 @komamitsu @brfrn169 @feeblefakie