Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ScalarDB Server #2050

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Remove ScalarDB Server #2050

merged 5 commits into from
Jul 29, 2024

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 8, 2024

Description

This PR removes ScalarDB Server related things.

Related issues and/or PRs

N/A

Changes made

  • Removed ScalarDB Server related files.
  • Removed ScalarDB Server things from the GitHub actions workflow.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Jul 8, 2024
Torch3333
Torch3333 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@komamitsu
Copy link
Contributor

@brfrn169 https://github.com/scalar-labs/scalardb/blob/29a7721c6093a27a4eb3584c4f15a5e506052843/core/src/test/java/com/scalar/db/config/DatabaseConfigTest.java still contains a few test cases for grpc. They can be also removed?

@brfrn169
Copy link
Collaborator Author

brfrn169 commented Jul 9, 2024

@brfrn169 https://github.com/scalar-labs/scalardb/blob/29a7721c6093a27a4eb3584c4f15a5e506052843/core/src/test/java/com/scalar/db/config/DatabaseConfigTest.java still contains a few test cases for grpc. They can be also removed?

@komamitsu Good catch! Fixed in 6518c9e. Thanks.

komamitsu
komamitsu approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

feeblefakie
feeblefakie approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 marked this pull request as draft July 11, 2024 05:48
@brfrn169 brfrn169 marked this pull request as ready for review July 26, 2024 03:56
@brfrn169 brfrn169 force-pushed the remove-scalardb-server branch from c6dc008 to 77e7332 Compare July 26, 2024 05:56
@brfrn169 brfrn169 force-pushed the remove-scalardb-server branch from 4d460de to 6e2a802 Compare July 27, 2024 00:32
kota2and3kan
kota2and3kan approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 88e639f into master Jul 29, 2024
48 checks passed
@brfrn169 brfrn169 deleted the remove-scalardb-server branch July 29, 2024 06:59
@feeblefakie feeblefakie mentioned this pull request Jul 29, 2024
Closed
brfrn169 added a commit that referenced this pull request Jul 29, 2024
@brfrn169
Remove ScalarDB Server (#2050)
d78f4a9
@brfrn169 brfrn169 mentioned this pull request Jul 29, 2024
Merged
@brfrn169 brfrn169 mentioned this pull request Sep 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kota2and3kan kota2and3kan kota2and3kan approved these changes

@Torch3333 Torch3333 Torch3333 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brfrn169 @komamitsu @feeblefakie @Torch3333 @kota2and3kan