Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported databases #1419

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Update supported databases #1419

merged 1 commit into from
Dec 27, 2023

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Dec 27, 2023 •
edited
Loading

Description

This PR updates the supported databases for ScalarDB 3.11.

Related issues and/or PRs

N/A

Changes made

  • Added supported databases for ScalarDB 3.11

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Dec 27, 2023
komamitsu
komamitsu approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

josh-wong
josh-wong approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@josh-wong josh-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!🙇‍♂️

kota2and3kan
kota2and3kan approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169
Copy link
Collaborator Author

@josh-wong Do we still need to apply this change to 3.5 and 3.6 branches?

feeblefakie
feeblefakie approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 7eccb59 into master Dec 27, 2023
23 checks passed
@feeblefakie feeblefakie deleted the update-supported-databases branch December 27, 2023 14:34
feeblefakie pushed a commit that referenced this pull request Dec 27, 2023
@brfrn169
Update supported databases (#1419)
50a2e4e
@feeblefakie feeblefakie mentioned this pull request Dec 27, 2023
Merged
feeblefakie pushed a commit that referenced this pull request Dec 27, 2023
@brfrn169
Update supported databases (#1419)
d2503dd
@feeblefakie feeblefakie mentioned this pull request Dec 27, 2023
Merged
feeblefakie pushed a commit that referenced this pull request Dec 27, 2023
@brfrn169
Update supported databases (#1419)
d0e91d4
@feeblefakie feeblefakie mentioned this pull request Dec 27, 2023
Merged
feeblefakie pushed a commit that referenced this pull request Dec 27, 2023
@brfrn169
Update supported databases (#1419)
3d8e745
@feeblefakie feeblefakie mentioned this pull request Dec 27, 2023
Merged
brfrn169 added a commit that referenced this pull request Dec 28, 2023
@brfrn169
Update supported databases (#1419)
c1530e2
@brfrn169 brfrn169 mentioned this pull request Dec 28, 2023
Merged
brfrn169 added a commit that referenced this pull request Dec 28, 2023
@brfrn169
Update supported databases (#1419)
1dd9499
@brfrn169 brfrn169 mentioned this pull request Dec 28, 2023
Merged
@josh-wong
Copy link
Member

josh-wong commented Dec 28, 2023 •
edited
Loading

@brfrn169

@josh-wong Do we still need to apply this change to 3.5 and 3.6 branches?

Thank you for mentioning this, and sorry for the delayed reply. As I mentioned in greater detail on Slack, we don't need to update branches 3.5 or 3.6 since they are out of Maintenance Support.

This was referenced Dec 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kota2and3kan kota2and3kan kota2and3kan approved these changes

@josh-wong josh-wong josh-wong approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@komamitsu komamitsu komamitsu approved these changes

@Torch3333 Torch3333 Awaiting requested review from Torch3333

Assignees

@brfrn169 brfrn169

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brfrn169 @josh-wong @komamitsu @feeblefakie @kota2and3kan