Update documentation for the repair feature #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torch3333
changed the title
Torch3333
commented
Nov 20, 2023
| admin.repairNamespace("ns", options); | ||
| ``` | ||
|
|
||
| ### Repair a table |
There was a problem hiding this comment.
Even though the Admin API repairTable() method has existed since v3.6. A section in the api-guide and storage-abstraction docs was never added. Since the content will be different for the older doc versions since the method behavior is changing for the next release, I will create another PR for it.
Torch3333
requested review from
komamitsu,
brfrn169,
feeblefakie and
josh-wong
josh-wong
requested changes
Nov 22, 2023
schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaLoader.java
Outdated
Show resolved
Hide resolved
schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaLoader.java
Outdated
Show resolved
Hide resolved
schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaLoader.java
Outdated
Show resolved
Hide resolved
schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaLoader.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Wong <joshua.wong@scalar-labs.com>
Torch3333
force-pushed
the
update_repair_doc
branch
from
3743849 to
858fab4
Compare
josh-wong
approved these changes
Nov 29, 2023
Co-authored-by: Josh Wong <joshua.wong@scalar-labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Admin API
repairTable()method has existed since v3.6, but its behavior has changed (cf. #1125). Also, a newrepairNamespacemethod was added to the Admin API (#1107). Finally, the--repair-allcommand of the Schema Loader will not only repair table but also repair namespace. (#1203)This PR will update the documentation for these changes.
Related issues and/or PRs
--repair-allcommand will also repair namespaces #1203Changes made
repairTableandrepairNamespacerepairTableandrepairNamespaceChecklist
Additional notes (optional)
N/A
Release notes
N/A