Port core to Scala.js #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2017
This was referenced Apr 23, 2017
- Use metaconfig-hocon on JS - Use metaconfig-typesafe-config on JVM The first unit test passes on JS!
Let's wait for scalameta/scalameta#812 to get fixed so we can run the full test suite in Scala.js
This commit reorganizes the top-level directories to follow a consistent naming convention: scalafmt-MODULE. I'm doing this in this PR because the files have already moved into `shared/` directories so URLs to previous files will get lost anyways. I like the consistent naming scheme because it feels easier to get an overview of the project.
olafurpg
force-pushed
the
scala.js
branch
3 times, most recently
from
49bda07 to
11a5cb4
Compare
pjrt
pushed a commit
to pjrt/scalafmt
that referenced
this pull request
May 22, 2017
* Move core tests to tests module * Remove unused sbt-pack * Move cli/test to tests/test * Tiny cleanup in build.sbt * Move src to shared/src * Abstract over config backend. - Use metaconfig-hocon on JS - Use metaconfig-typesafe-config on JVM The first unit test passes on JS! * Format :v * Fix ci-slow command * Add a few more JS unit tests. Let's wait for scalameta/scalameta#812 to get fixed so we can run the full test suite in Scala.js * Skip CI_PUBLISH for ci-sbt-scalafmt * Move all the files! This commit reorganizes the top-level directories to follow a consistent naming convention: scalafmt-MODULE. I'm doing this in this PR because the files have already moved into `shared/` directories so URLs to previous files will get lost anyways. I like the consistent naming scheme because it feels easier to get an overview of the project. * Move scalafmt-readme back to readme/ * Update .scalafmt.conf * Fix ci-sbt-scalafmt command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit tricky to run the unit tests in JS because unit tests are written in external source files like this one https://github.com/scalameta/scalafmt/blob/0cbbbac5b90d7ce104a6fcca781bb4a479a0d27b/core/src/test/resources/test/DynamicStyle.stat
Ideally, we should add file IO support in scalameta-io for node.js, which can be used for running unit tests in sbt. However, I'm tempted to leave that for another PR and write a few basic unit tests without file IO and merge PR.
shared/directories.